[PATCH] D55280: [CTU] Make loadExternalAST return with non nullptr on success

[Aleksei Sidorin via Phabricator via cfe-commits]

a_sidorin requested changes to this revision.
a_sidorin added a comment.
This revision now requires changes to proceed.

Hi Gabor,
There is a code in getExternalAST:

  std::unique_ptr<ASTUnit> LoadedUnit(ASTUnit::LoadFromASTFile(
      ASTFileName, CI.getPCHContainerOperations()->getRawReader(),
      ASTUnit::LoadEverything, Diags, CI.getFileSystemOpts()));
  Unit = LoadedUnit.get();
  FileASTUnitMap[ASTFileName] = std::move(LoadedUnit);

And `ASTUnit::LoadFromASTFile()`can return nullptr. Actually, there is a 
problem in `loadExternalAST()` - it ignores this fact.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55280/new/

https://reviews.llvm.org/D55280



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits