NoQ added a comment.

It's a flag that was removed but old soft doesn't know that it was removed, and 
it won't be fixed because it's old. I guess a typo would have caused the same 
problem.

Not urgent, no pressure. Yes, i believe this patch is good and should stay 
there. At the same time, by the looks of it, coming up with a fix for this 
"problem" may be annoying.



================
Comment at: lib/Driver/ToolChains/Clang.cpp:3307-3309
 void Clang::ConstructJob(Compilation &C, const JobAction &JA,
                          const InputInfo &Output, const InputInfoList &Inputs,
                          const ArgList &Args, const char *LinkingOutput) const 
{
----------------
Szelethus wrote:
> Hmmm. If we just moved the 
> `CmdArgs.push_back("-analyzer-config-compatibility-mode=true");` line to this 
> function (which actually invokes `RenderAnalyzerOptions`), that would solve 
> the issue, wouldn't it? Or somewhere in an even more general driver function.
Yeah, but it's not going to be an `AnalyzeJobAction` in the problematic case. 
So you'd have to add this flag to every single clang invocation.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53280/new/

https://reviews.llvm.org/D53280



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to