Szelethus added a comment. Thanks for the fix! :)
In D55226#1318853 <https://reviews.llvm.org/D55226#1318853>, @Pierre-vh wrote: > Hello again! I updated the diff and completely removed the outer if. Please > let me know what you think! If we're sure that `Target` isn't a `nullptr`, it's fine not to use a defensive check, but I think we definitely should add `assert(Target);` before using it. ================ Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:662 + // Issue a warning. ---------------- No need for this newline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
