Szelethus added inline comments.
================ Comment at: test/Analysis/ctu-main.cpp:6 // RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -analyze -analyzer-checker=core,debug.ExprInspection -analyzer-config experimental-enable-naive-ctu-analysis=true -analyzer-config ctu-dir=%T/ctudir -verify %s +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -analyze -analyzer-checker=core,debug.ExprInspection -analyzer-config experimental-enable-naive-ctu-analysis=true -analyzer-config ctu-dir=%T/ctudir -analyzer-display-ctu-progress 2>&1 %s | FileCheck %s + ---------------- martong wrote: > martong wrote: > > Szelethus wrote: > > > I think these RUN lines would really benefit from introducing line breaks. > > Yes, I agree. Unfortunately, I could not figure out how to break them. > > Using a simple "\" at around the 80th column gives `Test has unterminated > > run lines (with '\')`. If I use block comments with "\" the same happens. > > If I use block comments and don't use the "\" then the second line is not > > interpreted. Is it really possible to break RUN lines? I could not find > > anything about that in the online docs. > Oh, I just have found your other comment to the other patch. So yes, it is > indeed possible to break this line. I updated the patch accordingly. The > other long lines which are already there I am going to change in an > independent patch: (https://reviews.llvm.org/D55129). Is there any particular reason why we use `%clang_cc1 -analyze` as opposed to `%clang_analyze_cc1`? If not, lets change it. By the way, thanks! This looks neat. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55135/new/ https://reviews.llvm.org/D55135 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
