aaron.ballman added a comment. Looks reasonable, but similar to D55189 <https://reviews.llvm.org/D55189>, can more of the implementation be pushed into a .cpp file rather than left in a header?
Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://reviews.llvm.org/D55190 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits