JonasToth added a comment.
Hi russell
thank you for the patch! As I am not a clang-format reviewers these are only
general things, and Nits anyway ;)
Hope the reviewers I added will evaluate better.
================
Comment at: lib/Format/WhitespaceManager.cpp:54
Tok.Decision = (Newlines > 0) ? FD_Break : FD_Continue;
- Changes.push_back(Change(Tok, /*CreateReplacement=*/true,
Tok.WhitespaceRange,
- Spaces, StartOfTokenColumn, Newlines, "", "",
- InPPDirective && !Tok.IsFirst,
+ auto OriginalWhitespaceRange = Tok.WhitespaceRange;
+
----------------
is this a SourceRange? Please spell out the type, as there are different kind
of ranges.
================
Comment at: unittests/Format/FormatTest.cpp:9159
"}"));
+
Tab.AlignConsecutiveAssignments = true;
----------------
Spurious change.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54881/new/
https://reviews.llvm.org/D54881
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
