stephanemoore added a comment.

In D55101#1314716 <https://reviews.llvm.org/D55101#1314716>, @benhamilton wrote:
> IMHO we should just disable this check entirely for C++ files (including 
> Objective-C++).
>
> Since Objective-C++ files will have a mix of the Google Objective-C and 
> Google C++ styles, I think there will be too many places where we'll hit 
> conflicts like this (there are likely more).


Would you be okay with landing this fix and if we get any further reports for 
Objective-C++ sources then we can suppress it in all C++/Objective-C++ sources? 
I think there is enough value to enforcing the naming conventions on 
non-namespaced C functions in Objective-C++ to justify a simple followup fix. 
If other issues are reported after this then I also agree that enforcement in 
Objective-C++ sources may incur more overhead than it's worth.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55101/new/

https://reviews.llvm.org/D55101



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to