NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Makes perfect sense to me! ================ Comment at: test/Analysis/iterator-range.cpp:190 + auto i0 = L.begin(); + --i0; // expected-warning{{Iterator accessed outside of its range}} +} ---------------- I guess we'll have to come up with a separate warning text for this case, as there's no access happening through the iterator. Regardless of how the final message would look, i suggest adding logic for having a different message now, so that we didn't forget about this case later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53812/new/ https://reviews.llvm.org/D53812 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits