NoQ marked an inline comment as done. NoQ added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2383-2384 + if (RS == OldRS) + return; + ---------------- NoQ wrote: > Szelethus wrote: > > Hmmm, I guess we return here because if `RegionState` is unchanged, so > > should be `ReallocPairs` and `FreeReturnValue`, correct? > Yeah, kinda. Deserves a comment, i guess. Or even an assertion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54013/new/ https://reviews.llvm.org/D54013 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
