aaron.ballman added a comment.
This is a really nice cleanup, thank you!
================
Comment at: lib/AST/ASTDumper.cpp:114-115
+ public ConstStmtVisitor<ASTDumper>,
+ public CommentVisitorBase<comments::make_const_ptr, ASTDumper, void,
+ const FullComment *>,
+ public TypeVisitor<ASTDumper> {
----------------
Why not inherit from `ConstCommentVisitor` instead?
================
Comment at: lib/AST/ASTDumper.cpp:2684
-void ASTDumper::VisitTextComment(const TextComment *C) {
+void ASTDumper::VisitTextComment(const TextComment *C, const FullComment *FC) {
OS << " Text=\"" << C->getText() << "\"";
----------------
If the argument isn't used in the function, can you drop the identifier for it
from the parameter declaration? (Same elsewhere.)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55070/new/
https://reviews.llvm.org/D55070
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
