This revision was automatically updated to reflect the committed changes. Closed by commit rC347895: Simplify the __builtin_constant_p test that was used to catch rC347417 failure (authored by MaskRay, committed by ).
Changed prior to commit: https://reviews.llvm.org/D54964?vs=175543&id=175902#toc Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54964/new/ https://reviews.llvm.org/D54964 Files: test/SemaCXX/constant-expression-cxx1y.cpp Index: test/SemaCXX/constant-expression-cxx1y.cpp =================================================================== --- test/SemaCXX/constant-expression-cxx1y.cpp +++ test/SemaCXX/constant-expression-cxx1y.cpp @@ -1123,10 +1123,7 @@ } // namespace IndirectFields -constexpr bool __constant_string_p(const char *__s) { - while (__builtin_constant_p(*__s) && *__s) - __s++; +constexpr bool indirect_builtin_constant_p(const char *__s) { return __builtin_constant_p(*__s); } - -constexpr bool n = __constant_string_p("a"); +constexpr bool n = indirect_builtin_constant_p("a");
Index: test/SemaCXX/constant-expression-cxx1y.cpp =================================================================== --- test/SemaCXX/constant-expression-cxx1y.cpp +++ test/SemaCXX/constant-expression-cxx1y.cpp @@ -1123,10 +1123,7 @@ } // namespace IndirectFields -constexpr bool __constant_string_p(const char *__s) { - while (__builtin_constant_p(*__s) && *__s) - __s++; +constexpr bool indirect_builtin_constant_p(const char *__s) { return __builtin_constant_p(*__s); } - -constexpr bool n = __constant_string_p("a"); +constexpr bool n = indirect_builtin_constant_p("a");
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits