Szelethus added a comment. In D55051#1312666 <https://reviews.llvm.org/D55051#1312666>, @baloghadamsoftware wrote:
> In D55051#1312660 <https://reviews.llvm.org/D55051#1312660>, @Szelethus wrote: > > > Have you seen a crash resulting from this? Is supplying a test case > > feasable? I know that some of these errors are extremely hard to reproduce. > > > > Edit: Nevertheless, looks good to me. > > > There could be probably a test provided, but the bug is very obvious if you > look at the code. Also if you compare it with the first version of the > original patch. I'm sold on that. Let's wait for someone else then to formally accept. Please note that AFAIK the merge request deadline for 7.0.1 is tomorrow (nov. 30), so if putting this in is critical, writing a cfe-dev mail with a scary title may be a good idea. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55051/new/ https://reviews.llvm.org/D55051 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
