riccibruno added a comment. In D52879#1309856 <https://reviews.llvm.org/D52879#1309856>, @mantognini wrote:
> In D52879#1309734 <https://reviews.llvm.org/D52879#1309734>, @riccibruno > wrote: > > > I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` > > (`Builtin::BI__builtin_classify_type`, `Builtin::BI__builtin_constant_p`, > > `Builtin::BI__builtin_dump_struct` and so on...). > > > > Is there a reason for not removing them ? > > > Mainly because I was focusing on OpenCL builtins and was confident about > changing those, but wanted to be conservative on code that I don't test/work > with. If one wanted to remove those, I would encourage them to double check > their definitions are correct as I had to fix > (https://reviews.llvm.org/D52875) some for OpenCL. Got it. Thanks for explanation. Perhaps you could leave a TODO here with a note including what you just said so that we don't forget about it in the future (including the advice to double check the definition) ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/ https://reviews.llvm.org/D52879 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
