sammccall marked 3 inline comments as done. sammccall added a comment. In https://reviews.llvm.org/D54691#1302622, @ilya-biryukov wrote:
> Overall LG. The only concerning bit is that the initialization of the `UFE` > is now scattered across the function body. > Grouping `File` and `DeferredOpen` into a struct or adding a comment that > those are initialized separately from the rest of the fields might make it > more evident what's going on. WDYT? I added a comment in getFile() where ~all the UFE fields are initialized that File and DeferredOpen are initialized above. Added a redundant initialization in getVirtualFile() for clarity. Repository: rC Clang https://reviews.llvm.org/D54691 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
