balazske marked 3 inline comments as done. balazske added a comment. If we change signature of `Import` now, other parts of the code (in clang and LLDB) would not compile (without changing to use the new kind of Import). If there is a `Import_New` the old code can still compile and can be changed later.
================ Comment at: lib/AST/ASTImporter.cpp:7889 + return NestedNameSpecifier::Create(ToContext, Prefix, + Import(FromNNS->getAsIdentifier())); ---------------- a_sidorin wrote: > We can use Import_New if we change this code, like it is done below. For `IdentifierInfo` there is no Import_New because this is the one kind of import that can not fail, it remains the same Import as before (does not return `Expected`). Repository: rC Clang https://reviews.llvm.org/D53818 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
