lebedev.ri added inline comments.
================ Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:64 + diag(ArrayType->getBeginLoc(), + isa<VariableArrayType>(ArrayType->getTypePtr()) ? UseVector : UseArray); +} ---------------- JonasToth wrote: > Why `isa<>` and not `isVariableArrayType()` (does it exist?) > `isa<>` would not resolve typedefs, but I think they should be considered. Hmm, interesting point. I'm not sure ATM how to expose it in tests, but it counts as a cleanup anyway. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53771 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
