hokein added a comment.

Thanks for the patch and nice improvements.

Some initial thoughts:

- The output of clang-tidy diagnostic is YAML, and YAML is not an 
space-efficient format (just for human readability). If you want to save space 
further, we might consider using some compressed formats, e.g. llvm::bitcode. 
Given the reduced YAML result (5.4MB) is promising, this might not matter.
- clang-tidy itself doesn't do deduplication, and `run-clang-tidy.py` seems an 
old way of running clang-tidy in parallel. The python script seems become more 
complicated now.  We have `AllTUsToolExecutor` right now, which supports 
running clang tools on a compilation database in parallel, so another option 
would be to use `AllTUsToolExecutor` in clang-tidy, and we can do deduplication 
inside clang-tidy binary (in reduce phase), which should be faster than the 
python script (spawn new clang-tidy processes and do round-trip of all the data 
through YAML-on-disk).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54141



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to