On Mon, Nov 5, 2018, 13:58 Ilya Biryukov via Phabricator < revi...@reviews.llvm.org wrote:
> ilya-biryukov added a comment. > > > There's the usual concern that the current behavior is reasonable and > people like it. > > I think it would be reasonable to say that a large portion of C++ users > are used to the behavior that this patch introduces. > Specifically, all IDEs (Clion, Eclipse, Visual Studio for certain, not > sure about XCode) will see the contents of the headers that the user typed > and not the other way around. > It does not cause any inconsistencies there, the IDE will save all your > open files when you hit "build". That also means reading files from the > filesystem gives non-useful errors in that case, because the build will > actually see the files from the editors. > I agree, which is why I described both behaviors as reasonable :-) I don't this this address either of my concerns, though. > > Repository: > rCTE Clang Tools Extra > > https://reviews.llvm.org/D54077 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits