a_sidorin added a comment.

Hi Gabor,
Thank you for the patch. The reason for this change looks clear. However, I 
don't think omitting this comparison completely is what we want here. Instead, 
we can do a dance similar to `ASTContext::mergeFunctionTypes()` where all 
attributes but NoReturn are compared. What do you think?


Repository:
  rC Clang

https://reviews.llvm.org/D53699



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D53699: [ASTImport... Aleksei Sidorin via Phabricator via cfe-commits

Reply via email to