a_sidorin added a comment.
Hi Gabor,
Thank you for the patch. I looks reasonable but I have some questions.
================
Comment at: lib/AST/ASTImporter.cpp:2310
+ D->getUnderlyingType(), FoundTypedef->getUnderlyingType())) {
+ QualType FromUT = D->getUnderlyingType();
+ QualType FoundUT = FoundTypedef->getUnderlyingType();
----------------
We can move these two vars upper and use them in the condition.
================
Comment at: lib/AST/ASTImporter.cpp:2314
+ // already have a complete underlying type then return with that.
+ if (!FromUT->isIncompleteType() && !FoundUT->isIncompleteType())
return Importer.MapImported(D, FoundTypedef);
----------------
This condition omits the case where both types are complete. Should we use
`FromUT->isIncompleteType == FoundUT-isIncompleteType()` instead?
Repository:
rC Clang
https://reviews.llvm.org/D53693
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
