Szelethus planned changes to this revision.
Szelethus added a comment.
@xazax.hun observed that the way `diagnostics` looks like is this:
diagnostics
report 1
notes
macro_expansions
path
executed_lines
report 2
...
Buuuut, if I didn't insist on this structure, but rather print macros at the
end of the report, we wouldn't need all this hackery (converting a immutable
container, into a mutable one, and then actually modifying the path). This
however does imply that macro pieces have to be collected, which would imply
the need for adding //yet another// parameter to //every single function// in
this file. I think the time has come to collect them in a class, so I'll put
this patch on hold.
Mind you, the rest of the patches don't contain logic that depends on this
patch.
https://reviews.llvm.org/D52742
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
