lebedev.ri added inline comments.
================ Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:54 + +namespace { + ---------------- Extend the namespace /\ above, so that function is also covered? ================ Comment at: clang-tidy/readability/ConstValueReturnCheck.h:19-20 + +/// Suggests removal of the `const` qualifier from any function that returns a +/// const type. +/// ---------------- It isn't immediately clear whether this is talking about ``` const T func(); ``` or ``` T func() const; // member function ``` I'd suggest to emphasize that this is about the const on the return type, not on the function. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53025 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits