george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed.
Good to go provided you will add an example. If we want to be serious about this page, it really has to be auto-generated (like clang-tidy one), but I understand that this is a larger undertaking. ================ Comment at: www/analyzer/available_checks.html:496 +<div class="example"><pre> +<!-- TODO: Add examples. And also test files for this checker. --> +</pre></div></div></td></tr> ---------------- Szelethus wrote: > george.karpenkov wrote: > > If we don't have a description, let's just drop it. > I added a description, I'd strongly prefer keeping this in. Also would need a short example. Usually one can be found in tests. https://reviews.llvm.org/D53069 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
