[PATCH] D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

[Marek Kurdej via Phabricator via cfe-commits]

curdeius updated this revision to Diff 170101.
curdeius added a comment.

Applied changes as per comments.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53372

Files:
  test/clang-tidy/readability-else-after-return-if-constexpr.cpp


Index: test/clang-tidy/readability-else-after-return-if-constexpr.cpp
===================================================================
--- test/clang-tidy/readability-else-after-return-if-constexpr.cpp
+++ test/clang-tidy/readability-else-after-return-if-constexpr.cpp
@@ -6,7 +6,7 @@
     return;
   else
     return;
-  // CHECK-MESSAGES: [[@LINE-2]]:3: warning:
+  // CHECK-MESSAGES: [[@LINE-2]]:3: warning: do not use 'else' after 'return'
 
   if constexpr (sizeof(int) > 4)
     return;
@@ -20,4 +20,3 @@
   else
     return;
 }
-// CHECK-NOT: warning:



Index: test/clang-tidy/readability-else-after-return-if-constexpr.cpp
===================================================================
--- test/clang-tidy/readability-else-after-return-if-constexpr.cpp
+++ test/clang-tidy/readability-else-after-return-if-constexpr.cpp
@@ -6,7 +6,7 @@
     return;
   else
     return;
-  // CHECK-MESSAGES: [[@LINE-2]]:3: warning:
+  // CHECK-MESSAGES: [[@LINE-2]]:3: warning: do not use 'else' after 'return'
 
   if constexpr (sizeof(int) > 4)
     return;
@@ -20,4 +20,3 @@
   else
     return;
 }
-// CHECK-NOT: warning:

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits