craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land.
LGTM with that one style comment fixed. ================ Comment at: lib/Driver/ToolChains/Clang.cpp:1743 + if (!Args.hasFlag(options::OPT_mtls_direct_seg_refs, + options::OPT_mno_tls_direct_seg_refs, true)) + CmdArgs.push_back("-mno-tls-direct-seg-refs"); ---------------- minor - I think this line should be lined up with the start of the arguments to hasFlags on the previous line. https://reviews.llvm.org/D53102 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits