Author: juliehockett Date: Wed Oct 17 13:16:05 2018 New Revision: 344707 URL: http://llvm.org/viewvc/llvm-project?rev=344707&view=rev Log: [clang-doc] Bringing bitcode tests in line
Makes bitcode tests line up with what's actually called in the tool. Should fix the failing bot. Also fixes a warning that was being thrown about initialization braces. Differential Revision: https://reviews.llvm.org/D53381 Modified: clang-tools-extra/trunk/unittests/clang-doc/BitcodeTest.cpp clang-tools-extra/trunk/unittests/clang-doc/ClangDocTest.h Modified: clang-tools-extra/trunk/unittests/clang-doc/BitcodeTest.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-doc/BitcodeTest.cpp?rev=344707&r1=344706&r2=344707&view=diff ============================================================================== --- clang-tools-extra/trunk/unittests/clang-doc/BitcodeTest.cpp (original) +++ clang-tools-extra/trunk/unittests/clang-doc/BitcodeTest.cpp Wed Oct 17 13:16:05 2018 @@ -18,15 +18,29 @@ namespace clang { namespace doc { -std::string writeInfo(Info *I) { +template <typename T> static std::string writeInfo(T &I) { SmallString<2048> Buffer; llvm::BitstreamWriter Stream(Buffer); ClangDocBitcodeWriter Writer(Stream); - // Check that there was no error in the write. - assert(Writer.dispatchInfoForWrite(I) == false); + Writer.emitBlock(I); return Buffer.str().str(); } +std::string writeInfo(Info *I) { + switch (I->IT) { + case InfoType::IT_namespace: + return writeInfo(*static_cast<NamespaceInfo *>(I)); + case InfoType::IT_record: + return writeInfo(*static_cast<RecordInfo *>(I)); + case InfoType::IT_enum: + return writeInfo(*static_cast<EnumInfo *>(I)); + case InfoType::IT_function: + return writeInfo(*static_cast<FunctionInfo *>(I)); + default: + return ""; + } +} + std::vector<std::unique_ptr<Info>> readInfo(StringRef Bitcode, size_t NumInfos) { llvm::BitstreamCursor Stream(Bitcode); Modified: clang-tools-extra/trunk/unittests/clang-doc/ClangDocTest.h URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-doc/ClangDocTest.h?rev=344707&r1=344706&r2=344707&view=diff ============================================================================== --- clang-tools-extra/trunk/unittests/clang-doc/ClangDocTest.h (original) +++ clang-tools-extra/trunk/unittests/clang-doc/ClangDocTest.h Wed Oct 17 13:16:05 2018 @@ -22,7 +22,7 @@ using EmittedInfoList = std::vector<std: static const SymbolID EmptySID = SymbolID(); static const SymbolID NonEmptySID = - SymbolID{1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}; + SymbolID{{1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}}; NamespaceInfo *InfoAsNamespace(Info *I); RecordInfo *InfoAsRecord(Info *I); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
