JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land.
Did you verify it actually works? Otherwise LGTM and because its a bug-fix you can commit and other concerns can be done post-commit. ================ Comment at: test/clang-tidy/check_clang_tidy.py:129 + + assert has_check_fixes or has_check_messages or has_check_notes # Remove the contents of the CHECK lines to avoid CHECKs matching on ---------------- Nit: Could you please move this assert three lines up? It looks that its actually checking the conditions established there. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
