zinovy.nis added a comment. In https://reviews.llvm.org/D52971#1262200, @ymandel wrote:
> Hi, > > It looks like this change has disabled FileCheck for all clang-tidy lit tests > that don't use check-prefixes. So, they all trivially pass even if their > CHECK... lines are wrong. An easy repro is just to randomly modify any CHECK > line in a lit file (e.g. > llvm/tools/clang/tools/extra/test/clang-tidy/readability-avoid-const-params-in-decls.cpp) > and run ninja check-clang-tools. > > In check_clang_tidy.py, if you add back (slightly modified) lines 93-95 to > the else branch (line 132), it seems to fix the problem. For example, add: > > has_check_fixes = check_fixes_prefixes[0] in input_text > has_check_messages = check_messages_prefixes[0] in input_text > has_check_notes = check_notes_prefixes[0] in input_text Oh, thanks. I'll fix it a bit later today. Sorry. Repository: rL LLVM https://reviews.llvm.org/D52971 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
