ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: include/clang/Driver/Job.h:33 // Re-export this as clang::driver::ArgStringList. -using llvm::opt::ArgStringList; +using ArgStringList = llvm::opt::ArgStringList; ---------------- Both approaches seem equivalent in that case, since we do want the re-export. So not sure we want to change this in the first place. But feel free to keep it too, don't have a strong opinion on this one. Repository: rC Clang https://reviews.llvm.org/D53135 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
