ilya-biryukov added a comment.
Overall LGTM, just a quick question to make sure I get what's going on.
================
Comment at: clangd/index/dex/Dex.cpp:184
+ ScopeIterators.push_back(iterator(Token(Token::Kind::Scope, Scope)));
+ if (Req.AnyScope || /*legacy*/ Req.Scopes.empty())
ScopeIterators.push_back(
----------------
Why do we still need to push `all()` with a trivial boost for `Scope.empty()`?
Is this a legacy way to specify "all scopes"?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52796
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
