sammccall added inline comments.
================
Comment at: lib/Lex/PPDirectives.cpp:1891
StringRef OriginalFilename = Filename;
if (!File) {
+ while (!Filename.empty() && !isAlphanumeric(Filename.front())) {
----------------
everything in this block is guarded by !Filename.empty().
Just add it to the if condition?
================
Comment at: lib/Lex/PPDirectives.cpp:1925
+ if (Filename.empty())
+ return;
----------------
this is mysterious - what does it solve? is it the right place to handle this
problem?
(You allude to a code complete crash - can you explain?)
Repository:
rC Clang
https://reviews.llvm.org/D52721
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
