compnerd added inline comments. Herald added a subscriber: libcxx-commits.
================ Comment at: include/filesystem:1396 - _LIBCPP_FUNC_VIS void __create_what(int __num_paths); ---------------- This possibly changes the meaning on other targets. What was the error that this triggered? ================ Comment at: test/support/test_macros.h:147 -# elif defined(_WIN32) -# if defined(_MSC_VER) && !defined(__MINGW32__) -# define TEST_HAS_C11_FEATURES // Using Microsoft's C Runtime library ---------------- I think that the condition here is inverted, and should be enabled for MinGW32. Repository: rCXX libc++ https://reviews.llvm.org/D51868 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits