mstorsjo accepted this revision. mstorsjo added inline comments. This revision is now accepted and ready to land.
================ Comment at: src/CMakeLists.txt:54 # Generate library list. -set(libraries ${LIBUNWINDCXX_ABI_LIBRARIES}) +set(libraries) append_if(libraries LIBUNWIND_HAS_C_LIB c) ---------------- cdavis5x wrote: > mstorsjo wrote: > > Is there any point in this line at all now, or can it be removed altogether? > I think `list(APPEND)` can fail if the variable doesn't exist. Okay - after reading the cmake docs, I agree that this seems to be the correct solution. Repository: rUNW libunwind https://reviews.llvm.org/D51644 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits