sammccall marked an inline comment as done. sammccall added inline comments.
================ Comment at: clangd/index/Index.cpp:158 + auto &SymRefs = Sym.second; + std::sort(SymRefs.begin(), SymRefs.end()); + // TODO: do we really need to dedup? ---------------- lebedev.ri wrote: > I noticed this by accident, but i'm pretty sure `std::sort()` should not be > used in LLVM sources **at all**. > `llvm::sort()` should be used **everywhere**. OK, I'll send a cleanup, thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51605 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits