sammccall added a comment. This looks reasonable! This is going to conflict with https://reviews.llvm.org/D51422, you might want to rebase.
================ Comment at: clang-tools-extra/clangd/index/MemIndex.h:26 + void build(std::shared_ptr<std::vector<const Symbol *>> Symbols, + size_t SlabSize=0); ---------------- could you make these names somewhat more abstract (e.g. BackingMemory rather than SlabSize)? The index shouldn't know/care which configuration of slabs it's built from. https://reviews.llvm.org/D51539 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
