sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/FileDistance.cpp:56 -constexpr const unsigned FileDistance::kUnreachable; - ---------------- I think this is required - are you sure it's never ODR-used? (Even if not, it's public, so it's not really possible to guarantee that) https://reviews.llvm.org/D51527 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
