Thanks! Looking at the list of failing bots that seems indeed to be the most likely explanation.
- Raphael Am Mi., 22. Aug. 2018 um 16:59 Uhr schrieb Shoaib Meenai <smee...@fb.com>: > > Might be because the constructed AST for a @finally on Windows will contain a > CapturedStmt: https://reviews.llvm.org/D47564. You probably want to > explicitly specify a non windows-msvc triple in the test. > > > > From: cfe-commits <cfe-commits-boun...@lists.llvm.org> on behalf of Raphael > Isemann via cfe-commits <cfe-commits@lists.llvm.org> > Reply-To: Raphael Isemann <teempe...@gmail.com> > Date: Wednesday, August 22, 2018 at 4:51 PM > To: "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> > Subject: r340483 - Revert "[ASTImporter] Add test for > ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt" > > > > Author: teemperor > > Date: Wed Aug 22 16:50:30 2018 > > New Revision: 340483 > > > > URL: > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D340483-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=SoW99711ISLe9RQ23xIpwyvcxXTd-Rxawo9VIXlpjuo&s=nc9gqViWXTB0N3ed5Zzdk_7AzYUFDgZpoxqOgBLI4nU&e= > > Log: > > Revert "[ASTImporter] Add test for > ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt" > > > > This test breaks llvm-clang-x86_64-expensive-checks-win. > > > > Removed: > > cfe/trunk/test/Import/objc-try-catch/Inputs/F.m > > cfe/trunk/test/Import/objc-try-catch/test.m > > > > Removed: cfe/trunk/test/Import/objc-try-catch/Inputs/F.m > > URL: > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_Import_objc-2Dtry-2Dcatch_Inputs_F.m-3Frev-3D340482-26view-3Dauto&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=SoW99711ISLe9RQ23xIpwyvcxXTd-Rxawo9VIXlpjuo&s=kFKOp3N2QmGe252ijaqC1sM6nD0j9xQCdVvuBjevcko&e= > > ============================================================================== > > --- cfe/trunk/test/Import/objc-try-catch/Inputs/F.m (original) > > +++ cfe/trunk/test/Import/objc-try-catch/Inputs/F.m (removed) > > @@ -1,28 +0,0 @@ > > -@interface Exception > > -@end > > -@interface OtherException > > -@end > > - > > -void f() { > > - @try { > > - Exception *e; > > - @throw e; > > - } > > - @catch (Exception *varname) { > > - } > > - @finally { > > - } > > - > > - @try { > > - } > > - @catch (Exception *varname1) { > > - @throw; > > - } > > - @catch (OtherException *varname2) { > > - } > > - > > - @try { > > - } > > - @finally { > > - } > > -} > > > > Removed: cfe/trunk/test/Import/objc-try-catch/test.m > > URL: > https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_test_Import_objc-2Dtry-2Dcatch_test.m-3Frev-3D340482-26view-3Dauto&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=SoW99711ISLe9RQ23xIpwyvcxXTd-Rxawo9VIXlpjuo&s=q6vS8avd9ajINxEtZW7uL9FWfjCwl4TGy4e6NfUNkZI&e= > > ============================================================================== > > --- cfe/trunk/test/Import/objc-try-catch/test.m (original) > > +++ cfe/trunk/test/Import/objc-try-catch/test.m (removed) > > @@ -1,40 +0,0 @@ > > -// RUN: clang-import-test -x objective-c++ -Xcc -fobjc-exceptions -dump-ast > -import %S/Inputs/F.m -expression %s | FileCheck %s > > - > > -// CHECK: ObjCAtTryStmt > > -// CHECK-NEXT: CompoundStmt > > -// CHECK-NEXT: DeclStmt > > -// CHECK-NEXT: VarDecl > > -// CHECK-NEXT: ObjCAtThrowStmt > > -// CHECK-NEXT: ImplicitCastExpr > > -// CHECK-NEXT: DeclRefExpr > > -// CHECK-NEXT: ObjCAtCatchStmt > > -// CHECK-NEXT: VarDecl > > -// CHECK-SAME: varname > > -// CHECK-SAME: 'Exception *' > > -// CHECK-NEXT: CompoundStmt > > -// CHECK-NEXT: ObjCAtFinallyStmt > > -// CHECK-NEXT: CompoundStmt > > - > > -// CHECK-NEXT: ObjCAtTryStmt > > -// CHECK-NEXT: CompoundStmt > > -// CHECK-NEXT: ObjCAtCatchStmt > > -// CHECK-NEXT: VarDecl > > -// CHECK-SAME: varname1 > > -// CHECK-SAME: 'Exception *' > > -// CHECK-NEXT: CompoundStmt > > -// CHECK-NEXT: ObjCAtThrowStmt > > -// CHECK-NEXT: <<NULL>> > > -// CHECK-NEXT: ObjCAtCatchStmt > > -// CHECK-NEXT: VarDecl > > -// CHECK-SAME: varname2 > > -// CHECK-SAME: 'OtherException *' > > -// CHECK-NEXT: CompoundStmt > > - > > -// CHECK-NEXT: ObjCAtTryStmt > > -// CHECK-NEXT: CompoundStmt > > -// CHECK-NEXT: ObjCAtFinallyStmt > > -// CHECK-NEXT: CompoundStmt > > - > > -void expr() { > > - f(); > > -} > > > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@lists.llvm.org > > https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=SoW99711ISLe9RQ23xIpwyvcxXTd-Rxawo9VIXlpjuo&s=7OwU_LMC-xQGUKoTBrJZVj4QNfVYAIM5ZZDXF_RS9oc&e= > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
