arphaman marked an inline comment as done. arphaman added inline comments.
================ Comment at: lib/Basic/SourceManager.cpp:1705 // If we haven't found what we want yet, try again, but this time stat() // each of the files in case the files have changed since we originally ---------------- ioeric wrote: > arphaman wrote: > > ioeric wrote: > > > Do we also need this in `findFileIDsForFile`? > > I don't really need this for my use case. > But it's not clear from the interface AFAICT. We should either handle this > case (maybe controlled with a flag), or make it clear in the API (with a > different name or documentation). Hmm, I think that would be better. I pulled that code into the `findFileIDsForFile` helper function, so we can call it in two modes now. It's probably good to do that check just in case in the new API too, so it does that check as well. https://reviews.llvm.org/D50926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
