rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/CodeGen/CodeGenFunction.cpp:989
+        CGM.getCodeGenOpts().StackAlignment)
+      Fn->addFnAttr("stackrealign");
+
----------------
mstorsjo wrote:
> erichkeane wrote:
> > Is there not an attribute name for this already in LLVM?  I guess I'm 
> > otherwise fine with this, but would want @craig.topper or @rnk to confirm 
> > that we're Ok just sending this string as an attribute.
> I don't see one in llvm/include/llvm/IR/Attributes.td at least, and all other 
> occurrances in clang just use the plain string.
Yep, we use the string stackrealign attribute.


Repository:
  rC Clang

https://reviews.llvm.org/D51026



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to