ioeric added inline comments.
================ Comment at: lib/Basic/SourceManager.cpp:2035 + "Passed invalid source location!"); + assert(Start.isFileID() && End.isFileID() && Loc.isFileID() && + "Passed non-file source location!"); ---------------- Why do we disallow locations from macro expansions? ================ Comment at: lib/Basic/SourceManager.cpp:2049 + return false; + std::pair<FileID, unsigned> EndLoc = getDecomposedLoc(End); + // The point must be in the same file as the end location. ---------------- nit: the pattern seems repetitive. Maybe pull out a helper/lambda like: `isBeforeInSameFile(L1, L2)`? Repository: rC Clang https://reviews.llvm.org/D50740 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
