ahatanak added a comment.

A few points I forgot to mention:

- This optimization kicks in only in NonGC mode. I don't think we need to care 
much about GC anymore, so I think that's OK.

- There is a lot of redundancy among the copy/dispose helper function strings 
and the block layout string in the block descriptor name (they all encode the 
information about the captures), which can make the descriptor name long. If 
that becomes a problem, it's possible to encode the information in a way that 
shortens the descriptor name, but that would probably make the function that 
generates the name more complex.


Repository:
  rC Clang

https://reviews.llvm.org/D50783



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to