aaron.ballman added inline comments.

================
Comment at: include/clang/AST/ExprCXX.h:3436
   using const_arg_iterator = const Expr* const *;
+  using arg_const_range = llvm::iterator_range<const_arg_iterator>;
 
----------------
shuaiwang wrote:
> aaron.ballman wrote:
> > Please name this `const_arg_range` for consistency.
> `arg_const_range` is more widely in clang
`arg_const_range` makes no sense -- the range is of constant args, not an 
argument over a constant range. Also, it's weird to have `const_arg_iterator` 
with `arg_const_range` in the same class. I've cleaned up those few instances 
in r339527. Thanks for pointing this out!


Repository:
  rC Clang

https://reviews.llvm.org/D50605



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to