cdavis5x added inline comments.
================ Comment at: src/Unwind-seh.cpp:53 + +/// Exception cleanup routine used by \c __libunwind_frame_consolidate to +/// regain control after handling an SEH exception. ---------------- mstorsjo wrote: > I don't see any `__libunwind_frame_consolidate` anywhere, is this comment > outdated? Why yes it is. ================ Comment at: src/UnwindLevel1.c:35 +#if !_LIBUNWIND_SUPPORT_SEH_UNWIND + ---------------- mstorsjo wrote: > This probably works, but isn't `#if !defined(_LIBUNWIND_SUPPORT_SEH_UNWIND)` > more of the common form? I think I wrote this before the change to make that so took place, and I forgot to update this. Good catch. ================ Comment at: src/libunwind_ext.h:73 + #endif +extern int _unw_init_seh(unw_cursor_t *cursor, CONTEXT *ctx); +extern DISPATCHER_CONTEXT *_unw_seh_get_disp_ctx(unw_cursor_t *cursor); ---------------- mstorsjo wrote: > These are all both defined and called from Unwind-seh.cpp, so couldn't they > just be static functions within there? Probably. Done. Repository: rUNW libunwind https://reviews.llvm.org/D50564 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
