george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed.
================ Comment at: lib/StaticAnalyzer/Checkers/UninitializedPointee.cpp:78 +/// If for whatever reason dereferencing fails, returns with false. +static bool dereference(ProgramStateRef State, SVal &V, QualType &DynT); + ---------------- In general, using return values is better than out-parameters. Could you instead return `Optional<std::pair<SVal, QualType>>` ? https://reviews.llvm.org/D50509 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
