ioeric added inline comments.
================ Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:83 + + bool FoundFirstHead = false; + // Iterate through valid seqneces of three characters Fuzzy Matcher can ---------------- ioeric wrote: > It's probably unclear what `FoundFirstHead` and `FoundSecondHead` are for to > readers without context (i.e. we are looking first two HEADs). I think it's > would be cleaner if we handle this out side of the look e.g. record the first > head in the `Next` initialization loop above. Sorry, full of typos here: I think it would be cleaner if we handle this outside of the loop e.g. record the first head in the `Next` initialization loop above. https://reviews.llvm.org/D50517 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
