ahatanak added inline comments.
================
Comment at: lib/CodeGen/CGBlocks.cpp:1725
BlockFieldFlags Flags, bool EHOnly,
+ bool DisposeCannotThrow, VarDecl *Var,
CodeGenFunction &CGF) {
----------------
rjmccall wrote:
> Could you replace these two flags with something more semantic, like telling
> this function what the context of pushing the cleanup is — basically meaning,
> are we in the copy helper or the destroy helper? That will let you pull the
> comment explaining `DisposeCannotThrow` into this function, where it makes a
> lot more sense.
I thought about passing a single flag instead of passing two flags too. If we
are going to pass a single flag, should we still use two variables inside the
function, EHOnly and DisposeCannotThrow, to maintain the readability of the
code?
Repository:
rC Clang
https://reviews.llvm.org/D50152
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
