erik.pilkington added a comment.

In https://reviews.llvm.org/D50527#1194660, @rjmccall wrote:

> Assuming you've done enough source-compatibility testing to say with 
> reasonable confidence that this won't break anything, I think this is fine.  
> It's a core goal of Objective-C/C++ to allow the base language as a complete 
> subset if at all possible.


I don't really see how this could break source-compatibility, I don't believe 
there is a way to start a binary operator's RHS with a colon[1] or a r_square, 
so this change can only affect programs that were previously ill-formed. I'll 
run some internal builds and report back though, just to be paranoid.

[1] excluding the GNU conditional expr, which is handled because 
getIdentifierInfo will always return nullptr for '?'.


https://reviews.llvm.org/D50527



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to