aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:4081-4085
+ void unlockExclusive() EXCLUSIVE_UNLOCK_FUNCTION(mu_) {
+ mu_.Unlock();
+ }
+
+ void unlockShared() SHARED_UNLOCK_FUNCTION(mu_) {
----------------
aaronpuchert wrote:
> aaron.ballman wrote:
> > Nothing calls either of these functions within the test; is that intended?
> Yes, I just wanted to check that there are no warnings within the functions.
> Before the changes in `lib/Analysis/ThreadSafety.cpp`, we would get a warning
> "releasing mutex 'mu' using shared access, expected exclusive access" on line
> 4086.
>
> My changes address the attributes on the function being analyzed, not on a
> function that is called from the function being analyzed.
Ah, okay, thank you for the explanation. I wasn't aware that was previously
failing, so I didn't see the behavioral change.
Repository:
rC Clang
https://reviews.llvm.org/D50110
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
