ahatanak added inline comments.

================
Comment at: test/CodeGenCXX/block-byref-cxx-objc.cpp:36
+// CHECK: call void @_Block_object_dispose(
+
+int testB() {
----------------
ahatanak wrote:
> Should the second call to @_Block_object_dispose be an invoke if the 
> destructor can throw? The FIXME in CodeGenFunction::BuildBlockRelease seems 
> to imply that we should consider whether the destructor can throw.
I mean the first call, not the second call. If the call to A's destructor 
throws when the first object is being destructed, the second object should be 
destructed on the EH path.


Repository:
  rC Clang

https://reviews.llvm.org/D50152



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to