simark added a subscriber: eric_niebler. simark added a comment. @eric_niebler, question for you:
This patch causes clang to emit a `-Wnonportable-include-path` warning where it did not before. It affects the following test on Windows: https://github.com/llvm-mirror/clang/blob/master/test/PCH/case-insensitive-include.c The warning is currently not emitted for the **last** clang invocation (the one that includes PCH), because the real path value is not available, and therefore this condition is false: https://github.com/llvm-mirror/clang/blob/fe1098c84823b8eac46b0bfffc5f5788b6c26d1a/lib/Lex/PPDirectives.cpp#L2015 With this patch, the real path value is available, so we emit the warning. Is it on purpose that this warning is not emitted in this case? If not should I simply add `-Wno-nonportable-include-path` to the last clang invocation, as was done earlier with the first invocation? It seems to me like the warning is valid, even though we use precompiled headers. Repository: rC Clang https://reviews.llvm.org/D48903 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
